Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test behavior cosine with zeros #1434

Merged
merged 2 commits into from
Dec 11, 2020
Merged

test: add test behavior cosine with zeros #1434

merged 2 commits into from
Dec 11, 2020

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 10, 2020

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner December 10, 2020 17:57
@JoanFM JoanFM marked this pull request as draft December 10, 2020 17:57
@github-actions
Copy link

This PR closes: #1432

@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Dec 10, 2020
@JoanFM JoanFM changed the title test: add test showcasing problem in issue test: add test behavior cosine with zeros Dec 11, 2020
@JoanFM JoanFM marked this pull request as ready for review December 11, 2020 07:16
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1434 (5e842ae) into master (4bf2780) will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   82.12%   81.82%   -0.30%     
==========================================
  Files         113      109       -4     
  Lines        7095     6637     -458     
==========================================
- Hits         5827     5431     -396     
+ Misses       1268     1206      -62     
Impacted Files Coverage Δ
jina/types/ndarray/dense/numpy.py 97.36% <0.00%> (-2.64%) ⬇️
jina/logging/sse.py 92.53% <0.00%> (-2.63%) ⬇️
jina/peapods/zmq/__init__.py 82.02% <0.00%> (-1.97%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
jina/executors/evaluators/text/length.py 100.00% <0.00%> (ø)
jina/peapods/peas/gateway/grpc/helper.py 0.00% <0.00%> (ø)
jina/executors/evaluators/rank/precision.py 100.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0776230...d6d0e07. Read the comment docs.

@hanxiao hanxiao merged commit 978e130 into master Dec 11, 2020
@hanxiao hanxiao deleted the github-1432 branch December 11, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants