Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add latency tracking #1437

Merged
merged 10 commits into from
Dec 11, 2020
Merged

ci: add latency tracking #1437

merged 10 commits into from
Dec 11, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 11, 2020

🔴 changes in #1348 seem to make https://github.com/jina-ai/latency-tracking unusable, which implies breaking changes that were not discovered.

@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1437 (afd2f06) into master (ce5f094) will increase coverage by 0.15%.
The diff coverage is 82.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1437      +/-   ##
==========================================
+ Coverage   81.58%   81.73%   +0.15%     
==========================================
  Files         109      113       +4     
  Lines        6575     6761     +186     
==========================================
+ Hits         5364     5526     +162     
- Misses       1211     1235      +24     
Impacted Files Coverage Δ
jina/peapods/pods/__init__.py 84.00% <ø> (-0.31%) ⬇️
jina/types/sets/document.py 96.47% <ø> (ø)
jina/flow/yaml_parser/legacy.py 52.63% <52.63%> (ø)
jina/flow/yaml_parser/base.py 75.00% <75.00%> (ø)
jina/flow/yaml_parser/__init__.py 96.29% <96.29%> (ø)
jina/excepts.py 100.00% <100.00%> (ø)
jina/flow/yaml_parser/v1.py 100.00% <100.00%> (ø)
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021e099...60bcea5. Read the comment docs.

@hanxiao
Copy link
Member Author

hanxiao commented Dec 11, 2020

will solve gateway problem in a separate PR

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1913, delta to last 3 avg.: +0%
  • 🐎🐎🐎🐎 query QPS at 44, delta to last 3 avg.: +29%

Breakdown

Version Index QPS Query QPS
current 1913 44
0.8.3 1906 34
0.8.2 1913 34
0.8.1 1927 33

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit ded6127 into master Dec 11, 2020
@hanxiao hanxiao deleted the feat-add-latency-tracking branch December 11, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants