New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: helloworld evaluate html #1465
Conversation
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
b324f68
to
fdac4ad
Compare
Can we have the evaluator disablelable (however you write, that you are able to disable it)? For the speed test it would be nice to not run the evaluation, since that would be a quite a change since the very beginning in the measured functionality. Or we say, we don't care and it should be part of the hello-world. Would also be fine for me. Just wanted to raise awareness. |
latecny tracking works on its own way not running hello world directly (which I find odd actually). but safe for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes
fdac4ad
to
6a47ee0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Codecov Report
@@ Coverage Diff @@
## master #1465 +/- ##
==========================================
+ Coverage 82.76% 83.01% +0.25%
==========================================
Files 110 110
Lines 6381 6512 +131
==========================================
+ Hits 5281 5406 +125
- Misses 1100 1106 +6
Continue to review full report at Codecov.
|
Changes introduced
Add Evaluation value to helllo world html