Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helloworld evaluate html #1465

Merged
merged 2 commits into from Dec 16, 2020
Merged

feat: helloworld evaluate html #1465

merged 2 commits into from Dec 16, 2020

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 15, 2020

Changes introduced
Add Evaluation value to helllo world html

@JoanFM JoanFM requested a review from a team as a code owner December 15, 2020 16:33
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helloworld This issue/PR affects the helloworld area/helper This issue/PR affects the helper functionality component/resource labels Dec 15, 2020
@JoanFM
Copy link
Member Author

JoanFM commented Dec 15, 2020

image (10)

@github-actions
Copy link

github-actions bot commented Dec 15, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 2173, delta to last 3 avg.: -4%
  • 🐎🐎 query QPS at 41, delta to last 3 avg.: +8%

Breakdown

Version Index QPS Query QPS
current 2173 41
0.8.7 2262 37
0.8.6 2264 37
0.8.5 2269 37

Backed by latency-tracking. Further commits will update this comment.

jina/resources/helloworld.html Outdated Show resolved Hide resolved
@maximilianwerk
Copy link
Member

Can we have the evaluator disablelable (however you write, that you are able to disable it)? For the speed test it would be nice to not run the evaluation, since that would be a quite a change since the very beginning in the measured functionality. Or we say, we don't care and it should be part of the hello-world. Would also be fine for me. Just wanted to raise awareness.

@JoanFM
Copy link
Member Author

JoanFM commented Dec 15, 2020

Can we have the evaluator disablelable (however you write, that you are able to disable it)? For the speed test it would be nice to not run the evaluation, since that would be a quite a change since the very beginning in the measured functionality. Or we say, we don't care and it should be part of the hello-world. Would also be fine for me. Just wanted to raise awareness.

Can we have the evaluator disablelable (however you write, that you are able to disable it)? For the speed test it would be nice to not run the evaluation, since that would be a quite a change since the very beginning in the measured functionality. Or we say, we don't care and it should be part of the hello-world. Would also be fine for me. Just wanted to raise awareness.

latecny tracking works on its own way not running hello world directly (which I find odd actually). but safe for now

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

jina/helloworld/helper.py Outdated Show resolved Hide resolved
bhavsarpratik
bhavsarpratik previously approved these changes Dec 16, 2020
Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #1465 (c4d2153) into master (08fa53e) will increase coverage by 0.25%.
The diff coverage is 98.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
+ Coverage   82.76%   83.01%   +0.25%     
==========================================
  Files         110      110              
  Lines        6381     6512     +131     
==========================================
+ Hits         5281     5406     +125     
- Misses       1100     1106       +6     
Impacted Files Coverage Δ
jina/helloworld/components.py 96.42% <92.85%> (-3.58%) ⬇️
jina/helloworld/__init__.py 100.00% <100.00%> (ø)
jina/helloworld/helper.py 95.60% <100.00%> (+4.11%) ⬆️
jina/parser.py 86.40% <100.00%> (+0.11%) ⬆️
jina/clients/sugary_io.py 95.74% <0.00%> (-4.26%) ⬇️
jina/logging/profile.py 68.33% <0.00%> (-0.58%) ⬇️
jina/peapods/pods/__init__.py 84.00% <0.00%> (-0.22%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fa53e...6a47ee0. Read the comment docs.

@JoanFM JoanFM merged commit 1197dec into master Dec 16, 2020
@JoanFM JoanFM deleted the helloworld-evaluate-html branch December 16, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helloworld This issue/PR affects the helloworld area/helper This issue/PR affects the helper functionality component/resource size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants