Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename flow output_fn to on_done #1476

Merged
merged 10 commits into from
Dec 17, 2020
Merged

refactor: rename flow output_fn to on_done #1476

merged 10 commits into from
Dec 17, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 17, 2020

  • All examples/usage that using output_fn will receive a depreciation warning, it will be auto-casted to on_done
  • Make the signature of on_done, on_error, on_always visible in docstring
  • New flow inheritance, Flow(BaseFlow), AsyncFlow(BaseFlow)
  • New client inheritance, Client(BaseClient), AsyncClient(BaseClient)

@hanxiao hanxiao requested a review from a team as a code owner December 17, 2020 10:14
@jina-bot jina-bot added size/XL area/core This issue/PR affects the core codebase area/helloworld This issue/PR affects the helloworld area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/client component/flow labels Dec 17, 2020
@github-actions
Copy link

github-actions bot commented Dec 17, 2020

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 2131, delta to last 3 avg.: -10%
  • 😶 query QPS at 41, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 2131 41
0.8.7 2485 40
0.8.6 2364 42
0.8.5 2332 42

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added the area/docs This issue/PR affects the docs label Dec 17, 2020
@hanxiao hanxiao merged commit 8851e5b into master Dec 17, 2020
@hanxiao hanxiao deleted the refactor-outputfn branch December 17, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/helloworld This issue/PR affects the helloworld area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/client component/flow size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants