Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add commit lint feedback #1486

Merged
merged 8 commits into from
Dec 18, 2020
Merged

ci: add commit lint feedback #1486

merged 8 commits into from
Dec 18, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 18, 2020 •
edited
Loading

no need to reply commit lint problem manually

@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Dec 18, 2020
JoanFM
JoanFM previously approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one!

@github-actions
Copy link

github-actions bot commented Dec 18, 2020 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1870, delta to last 3 avg.: -2%
  • 😶 query QPS at 32, delta to last 3 avg.: +3%

Breakdown

Version Index QPS Query QPS
current 1870 32
0.8.8 1853 30
0.8.7 1943 31
0.8.6 1958 31

Backed by latency-tracking. Further commits will update this comment.

@JoanFM
Copy link
Member

JoanFM commented Dec 18, 2020

Thanks for your contribution ❤️
💔 Unforunately, this PR has one ore more bad commit messages, it can not be merged. To fix this problem, please refer to:

Note, other CI tests will not start until the commit messages get fixed.

Typo in Unfortunately @hanxiao

@hanxiao hanxiao merged commit a7f50a9 into master Dec 18, 2020
@hanxiao hanxiao deleted the ci-commit-lint branch December 18, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM left review comments

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanxiao @JoanFM @jina-bot