refactor: update helloworld evaluate #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoanFM
changed the title
jina-bot
added
size/M
area/core
Codecov Report
@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
+ Coverage 84.11% 84.16% +0.04%
==========================================
Files 105 105
Lines 5975 6049 +74
==========================================
+ Hits 5026 5091 +65
- Misses 949 958 +9
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
hanxiao
reviewed
Dec 18, 2020
| @@ -77,8 +82,11 @@ def write_html(html_path): | |||
| open(html_path, 'w') as fw: | |||
| t = fp.read() | |||
| t = t.replace('{% RESULT %}', '\n'.join(result_html)) | |||
| evaluation_percentage = evaluation_value/num_docs_evaluated * 100.0 | |||
| t = t.replace('{% EVALUATION %}', '{:.2f}%'.format(evaluation_percentage)) | |||
| precision_evaluation_percentage = evaluation_value['evaluate-Precision@5'] / num_docs_evaluated * 100.0 | |||
There was a problem hiding this comment.
I can do the trick to select any key containing Precision
There was a problem hiding this comment.
but why is it 5, shouldn't this be top_k?
There was a problem hiding this comment.
i see so the eval_at is an attribute in Executor, making it impossible to read from querylang/driver
class BaseRankingEvaluator(BaseEvaluator):
"""A :class:`BaseRankingEvaluator` evaluates the content of matches against the expected GroundTruth.
It is used to evaluate messages coming out from Indexers and Rankers and compares matches with groundtruths
"""
def __init__(self, eval_at: int, *args, **kwargs):
""""
:param eval_at: k at which evaluation is performed
"""
super().__init__(*args, **kwargs)
self.eval_at = eval_at
hanxiao
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.