Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: access token cred file for hub push #1492

Merged
merged 6 commits into from Dec 24, 2020
Merged

fix: access token cred file for hub push #1492

merged 6 commits into from Dec 24, 2020

Conversation

rutujasurve94
Copy link
Contributor

@rutujasurve94 rutujasurve94 commented Dec 19, 2020 •
edited

  • Fetches GITHUB_TOKEN from the env and makes it available during reading access token from credentials_file during ci run

@rutujasurve94 rutujasurve94 requested review from hanxiao and a team as code owners December 19, 2020 05:05
@rutujasurve94 rutujasurve94 marked this pull request as draft December 19, 2020 05:06
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing labels Dec 19, 2020
@rutujasurve94 rutujasurve94 changed the title fix: hub push cred file fix: access token cred file for hub push Dec 19, 2020
@github-actions
Copy link

github-actions bot commented Dec 19, 2020 •
edited

Latency summary

Current PR yields:

  • 😶 index QPS at 1748, delta to last 3 avg.: +2%
  • 🐢🐢 query QPS at 30, delta to last 3 avg.: -7%

Breakdown

Version Index QPS Query QPS
current 1748 30
0.8.12 1754 30
0.8.11 1685 33
0.8.10 1695 32

Backed by latency-tracking. Further commits will update this comment.

deepankarm
deepankarm requested changes Dec 21, 2020
View reviewed changes
tests/unit/docker/test_hub_build.py Outdated Show resolved Hide resolved
tests/unit/docker/test_hub_build.py Outdated Show resolved Hide resolved
tests/unit/docker/test_hub_build.py Outdated Show resolved Hide resolved
@jina-bot jina-bot added area/core This issue/PR affects the core codebase component/docker labels Dec 23, 2020
@rutujasurve94 rutujasurve94 marked this pull request as ready for review December 23, 2020 04:14
@codecov
Copy link

codecov bot commented Dec 23, 2020 •
edited

Codecov Report

Merging #1492 (3ff3c41) into master (5745d97) will increase coverage by 0.43%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1492      +/-   ##
==========================================
+ Coverage   84.13%   84.56%   +0.43%     
==========================================
  Files         108      108              
  Lines        6202     6259      +57     
==========================================
+ Hits         5218     5293      +75     
+ Misses        984      966      -18
Impacted Files Coverage Δ
jina/docker/hubapi.py 78.03% <55.55%> (+2.06%) ⬆️
jina/logging/profile.py 68.33% <0.00%> (-0.58%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.52% <0.00%> (+0.09%) ⬆️
jina/peapods/peas/gateway/rest/__init__.py 94.00% <0.00%> (+0.12%) ⬆️
jina/jaml/__init__.py 94.54% <0.00%> (+0.20%) ⬆️
jina/executors/indexers/vector.py 88.88% <0.00%> (+0.24%) ⬆️
jina/executors/rankers/__init__.py 93.33% <0.00%> (+0.31%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199445e...3ff3c41. Read the comment docs.

JoanFM
JoanFM requested changes Dec 23, 2020
View reviewed changes
tests/unit/docker/test_hub_build.py Outdated Show resolved Hide resolved
tests/unit/docker/test_hub_build.py Outdated Show resolved Hide resolved
JoanFM
JoanFM requested changes Dec 23, 2020
View reviewed changes
tests/unit/docker/test_hub_build.py Outdated Show resolved Hide resolved
@jina-bot jina-bot added size/M and removed size/S labels Dec 23, 2020
@rutujasurve94 rutujasurve94 force-pushed the fix-push-hub branch 2 times, most recently from 0a19e1e to 733721c Compare December 23, 2020 11:16
@rutujasurve94 rutujasurve94 force-pushed the fix-push-hub branch 3 times, most recently from debe3f2 to df62547 Compare December 23, 2020 12:14
deepankarm
deepankarm requested changes Dec 23, 2020
View reviewed changes
Copy link
Member

@deepankarm deepankarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more minor changes

tests/unit/docker/test_hub_build.py Outdated Show resolved Hide resolved
tests/integration/hub_usage/test_hub_usage.py Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@hanxiao hanxiao merged commit 822d075 into master Dec 24, 2020
@hanxiao hanxiao deleted the fix-push-hub branch December 24, 2020 08:59
@deepankarm deepankarm mentioned this pull request Dec 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM requested changes

@hanxiao hanxiao hanxiao approved these changes

@deepankarm deepankarm deepankarm approved these changes

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/docker size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rutujasurve94 @hanxiao @deepankarm @JoanFM @jina-bot