Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add JAML class and use pyyaml as backend #1495

Merged
merged 6 commits into from Dec 19, 2020
Merged

refactor: add JAML class and use pyyaml as backend #1495

merged 6 commits into from Dec 19, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 19, 2020

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner December 19, 2020 17:36
@jina-bot jina-bot added size/M area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/docker component/driver component/executor component/flow component/logging component/peapod component/resource component/type executor/meta labels Dec 19, 2020
@github-actions
Copy link

github-actions bot commented Dec 19, 2020 •
edited

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1704, delta to last 3 avg.: -6%
  • 😶 query QPS at 28, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1704 28
0.8.8 1840 29
0.8.7 1847 28
0.8.6 1766 28

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao linked an issue Dec 19, 2020 that may be closed by this pull request
Migrating from ruamel.yaml to PyYAML before 1.0 release #1471
Closed
@jina-bot jina-bot added size/L and removed size/M labels Dec 19, 2020
@jina-bot jina-bot added the area/cicd This issue/PR affects the cicd pipeline label Dec 19, 2020
@jina-bot jina-bot added the area/housekeeping This issue/PR is housekeeping label Dec 19, 2020
@hanxiao hanxiao merged commit 54e1b86 into master Dec 19, 2020
@hanxiao hanxiao deleted the refactor-rm-ruamel branch December 19, 2020 21:09
@hanxiao hanxiao mentioned this pull request Dec 20, 2020
Closed
@nan-wang nan-wang mentioned this pull request Dec 23, 2020
Closed
@nan-wang nan-wang added this to the v0.9 Breaking Changes milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatStark CatStark Awaiting requested review from CatStark

@JoanFM JoanFM Awaiting requested review from JoanFM JoanFM is a code owner

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/docker component/driver component/executor component/flow component/logging component/peapod component/resource component/type executor/meta size/L
Projects
None yet
Milestone
v0.9 Breaking Changes
Development

Successfully merging this pull request may close these issues.

Migrating from ruamel.yaml to PyYAML before 1.0 release
3 participants
@hanxiao @nan-wang @jina-bot