Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: little help to optimizer #1518

Merged
merged 3 commits into from
Dec 22, 2020
Merged

refactor: little help to optimizer #1518

merged 3 commits into from
Dec 22, 2020

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 21, 2020

Changes proposed to help to the optimizer code.

Specially the integration tests simplification

@JoanFM JoanFM requested a review from a team as a code owner December 21, 2020 17:33
@JoanFM JoanFM requested review from nan-wang and yuanbit and removed request for a team December 21, 2020 17:33
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Dec 21, 2020
@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1918, delta to last 3 avg.: -3%
  • 😶 query QPS at 35, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1918 35
0.8.10 1927 36
0.8.9 2066 33
0.8.5 1979 39

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM marked this pull request as draft December 21, 2020 18:46
@bhavsarpratik bhavsarpratik merged commit 2891a49 into feat-add-optimizer Dec 22, 2020
@bhavsarpratik bhavsarpratik deleted the little-help-optimizer branch December 22, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang Awaiting requested review from nan-wang

@yuanbit yuanbit Awaiting requested review from yuanbit

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoanFM @bhavsarpratik @jina-bot