Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): topk ql apply to sliceql and vector search #1522

Merged
merged 1 commit into from Dec 21, 2020
Merged

fix(client): topk ql apply to sliceql and vector search #1522

merged 1 commit into from Dec 21, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 21, 2020

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner December 21, 2020 22:24
@hanxiao hanxiao linked an issue Dec 21, 2020 that may be closed by this pull request
top_k no longer works for search #1521
Closed
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/client labels Dec 21, 2020
@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1757, delta to last 3 avg.: -2%
  • 😶 query QPS at 32, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1757 32
0.8.11 1770 34
0.8.10 1746 34
0.8.9 1889 30

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit ede2989 into master Dec 21, 2020
@hanxiao hanxiao deleted the fix-client-topk branch December 21, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsergiy imsergiy Awaiting requested review from imsergiy

@rutujasurve94 rutujasurve94 Awaiting requested review from rutujasurve94

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/client size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

top_k no longer works for search
2 participants
@hanxiao @jina-bot