Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for 1545 #1547

Merged
merged 7 commits into from
Dec 28, 2020
Merged

test: add test for 1545 #1547

merged 7 commits into from
Dec 28, 2020

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 28, 2020

Changes introduced
Add test proving the problem with #1545

@JoanFM JoanFM requested a review from a team as a code owner December 28, 2020 07:20
@github-actions
Copy link

This PR closes: #1545

1 similar comment
@github-actions
Copy link

This PR closes: #1545

@jina-bot jina-bot added size/XS area/testing This issue/PR affects testing labels Dec 28, 2020
@github-actions
Copy link

github-actions bot commented Dec 28, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 1883, delta to last 3 avg.: +0%
  • 😶 query QPS at 32, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1883 32
0.8.14 1873 32
0.8.13 1872 33
0.8.12 1848 32

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM marked this pull request as draft December 28, 2020 08:12
@hanxiao
Copy link
Member

hanxiao commented Dec 28, 2020

let me fix this real quick, taking this branch now

@JoanFM
Copy link
Member Author

JoanFM commented Dec 28, 2020

let me fix this real quick, taking this branch now

perfect thanks!

@hanxiao hanxiao marked this pull request as ready for review December 28, 2020 12:24
@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #1547 (1476a50) into master (3f5a588) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
+ Coverage   84.37%   84.69%   +0.31%     
==========================================
  Files         108      108              
  Lines        6311     6376      +65     
==========================================
+ Hits         5325     5400      +75     
+ Misses        986      976      -10     
Impacted Files Coverage Δ
jina/executors/metas.py 96.87% <ø> (ø)
jina/jaml/__init__.py 95.93% <100.00%> (+0.38%) ⬆️
jina/logging/profile.py 68.33% <0.00%> (-0.58%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.52% <0.00%> (+0.09%) ⬆️
jina/peapods/peas/gateway/rest/__init__.py 94.00% <0.00%> (+0.12%) ⬆️
jina/executors/indexers/vector.py 88.88% <0.00%> (+0.24%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66f14d...1476a50. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor component/jaml executor/meta size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index stored under metas['workspace']/None-{root.metas.pea_id}/ even when no parallelism is used
3 participants