Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document set dundermethod add and iadd #1555

Merged
merged 2 commits into from
Dec 29, 2020

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner December 28, 2020 21:16
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Dec 28, 2020
jina/types/sets/document.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 28, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 1763, delta to last 3 avg.: +0%
  • 😶 query QPS at 27, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1763 27
0.8.16 1772 27
0.8.15 1768 28
0.8.14 1700 27

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #1555 (f09fa5f) into master (228d317) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1555      +/-   ##
==========================================
+ Coverage   84.55%   84.87%   +0.31%     
==========================================
  Files         109      109              
  Lines        6417     6485      +68     
==========================================
+ Hits         5426     5504      +78     
+ Misses        991      981      -10     
Impacted Files Coverage Δ
jina/types/sets/document.py 96.15% <100.00%> (+0.45%) ⬆️
jina/logging/profile.py 68.33% <0.00%> (-0.58%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/enums.py 96.52% <0.00%> (+0.09%) ⬆️
jina/peapods/peas/gateway/rest/__init__.py 94.00% <0.00%> (+0.12%) ⬆️
jina/executors/indexers/crud_vector.py 93.51% <0.00%> (+0.18%) ⬆️
jina/executors/indexers/vector.py 88.02% <0.00%> (+0.29%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b54f31...f09fa5f. Read the comment docs.

@florian-hoenicke florian-hoenicke merged commit 94ace99 into master Dec 29, 2020
@florian-hoenicke florian-hoenicke deleted the feat-document-set-add branch December 29, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants