Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix visualization in notebook #1562

Merged
merged 2 commits into from
Dec 30, 2020
Merged

fix: fix visualization in notebook #1562

merged 2 commits into from
Dec 30, 2020

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 29, 2020

Fixes #1561

@JoanFM JoanFM requested a review from a team as a code owner December 29, 2020 18:22
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/flow labels Dec 29, 2020
@github-actions
Copy link

github-actions bot commented Dec 29, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 2013, delta to last 3 avg.: +0%
  • 😶 query QPS at 35, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 2013 35
0.8.16 2009 35
0.8.15 1968 35
0.8.14 2018 35

Backed by latency-tracking. Further commits will update this comment.

@JoanFM
Copy link
Member Author

JoanFM commented Dec 30, 2020

image

jina/flow/base.py Outdated Show resolved Hide resolved
Co-authored-by: Deepankar Mahapatro <deepankar.mahapatro@jina.ai>
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #1562 (4345e03) into master (2425e4c) will increase coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
+ Coverage   84.54%   84.65%   +0.11%     
==========================================
  Files         108      108              
  Lines        6346     6393      +47     
==========================================
+ Hits         5365     5412      +47     
  Misses        981      981              
Impacted Files Coverage Δ
jina/flow/base.py 89.03% <0.00%> (+0.08%) ⬆️
jina/logging/sse.py 94.28% <0.00%> (-1.03%) ⬇️
jina/logging/profile.py 68.33% <0.00%> (-0.58%) ⬇️
jina/executors/decorators.py 91.32% <0.00%> (-0.19%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/encoders/numeric/__init__.py 42.42% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad570b...65d82d4. Read the comment docs.

@deepankarm deepankarm merged commit afbc44e into master Dec 30, 2020
@deepankarm deepankarm deleted the fixvis branch December 30, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/flow size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jina Flow visualization with Inspect nodes
3 participants