Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: russian translation 101 #1572

Merged
merged 1 commit into from Jan 1, 2021
Merged

Conversation

florian-hoenicke
Copy link
Member

redoing pr with correct commit style
#1544

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1781, delta to last 3 avg.: +1%
  • 😶 query QPS at 31, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1781 31
0.8.16 1739 30
0.8.15 1773 31
0.8.14 1759 31

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #1572 (aef2ca1) into master (4a2c744) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1572      +/-   ##
==========================================
+ Coverage   84.35%   84.65%   +0.29%     
==========================================
  Files         108      108              
  Lines        6367     6367              
==========================================
+ Hits         5371     5390      +19     
+ Misses        996      977      -19     
Impacted Files Coverage Δ
jina/flow/base.py 88.94% <0.00%> (+0.51%) ⬆️
jina/docker/hubio.py 71.65% <0.00%> (+2.36%) ⬆️
jina/logging/sse.py 95.31% <0.00%> (+3.12%) ⬆️
jina/docker/hubapi.py 83.33% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2c744...3c1a19d. Read the comment docs.

@jina-ai jina-ai deleted a comment from github-actions bot Dec 31, 2020
Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 4f50e80 into master Jan 1, 2021
@nan-wang nan-wang deleted the fix-russian-translation-101 branch January 1, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue/PR affects the docs size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants