Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: two tests with same name #1573

Merged
merged 2 commits into from
Jan 4, 2021
Merged

fix: two tests with same name #1573

merged 2 commits into from
Jan 4, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner December 31, 2020 15:08
@jina-bot jina-bot added size/XS area/testing This issue/PR affects testing labels Dec 31, 2020
@github-actions
Copy link

github-actions bot commented Dec 31, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 1787, delta to last 3 avg.: -3%
  • 😶 query QPS at 30, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1787 30
0.8.21 1874 31
0.8.20 1861 31
0.8.19 1827 30

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 3, 2021

Codecov Report

Merging #1573 (ec66a85) into master (a431537) will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1573      +/-   ##
==========================================
+ Coverage   84.03%   84.41%   +0.38%     
==========================================
  Files         128      128              
  Lines        6600     6659      +59     
==========================================
+ Hits         5546     5621      +75     
+ Misses       1054     1038      -16     
Impacted Files Coverage Δ
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/flow/base.py 86.58% <0.00%> (+0.10%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
jina/peapods/runtimes/asyncio/rest/__init__.py 93.18% <0.00%> (+0.15%) ⬆️
jina/executors/indexers/vector.py 88.94% <0.00%> (+0.23%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7786c...9f98092. Read the comment docs.

@hanxiao hanxiao merged commit 8ecf5b3 into master Jan 4, 2021
@hanxiao hanxiao deleted the fix-two-tests-with-same-name branch January 4, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants