fix(remote): remote type check and pod invocation #1577
Conversation
jina-bot
added
size/S
area/core
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
+ Coverage 84.08% 84.44% +0.35%
==========================================
Files 128 128
Lines 6587 6660 +73
==========================================
+ Hits 5539 5624 +85
+ Misses 1048 1036 -12
Continue to review full report at Codecov.
|
deepankarm
changed the title
|
https://github.com/jina-ai/jinad/pull/78/checks?check_run_id=1643055891 |
| if isinstance(args, Dict): | ||
| # This is used when a Pod is created in a remote context, where peas & their connections are already given. | ||
| self.peas_args = args | ||
| else: | ||
| self.peas_args = self._parse_args(args) |
There was a problem hiding this comment.
when is dict used? inside JinadRuntime sending this to jinad?
There was a problem hiding this comment.
https://github.com/jina-ai/jina/blob/master/jina/peapods/runtimes/jinad/__init__.py#L28
before sending these args, they're converted to dict & on the receiving end, jinad converts dict to argparse
This needs to be fixed to make jina-ai/jinad#78 work.
jinadchecks will still fail with this PR.