New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cli): Fix small typo in cli parser #1578
Conversation
recheckcla |
Jina CLA check ✅ All Contributors have signed the CLA. |
Bad commit message, please refer to: |
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
I have read the CLA Document and I hereby sign the CLA |
@JoanFM hmm, I am a bit confused about what commit messages should I change it to. Do you mind giving me a pointer? |
if u look at the CI, this error shows up "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/jina/jina":"/github/workspace" wagoid/commitlint-github-action:1.8.0 ⧗ input: docs(cli): Fix small typo in parser ✖ found 1 problems, 0 warnings |
Codecov Report
@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
+ Coverage 84.08% 84.39% +0.30%
==========================================
Files 128 128
Lines 6587 6656 +69
==========================================
+ Hits 5539 5617 +78
+ Misses 1048 1039 -9
Continue to review full report at Codecov.
|
@JoanFM Thanks for the info! I have fixed the commit lint, but one of the CI is still failing. Is it relevant to this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
This is a tiny PR to fix a typo in the parser help menu