Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): Fix small typo in cli parser #1578

Merged
merged 1 commit into from Jan 4, 2021

Conversation

xinbinhuang
Copy link
Contributor

@xinbinhuang xinbinhuang commented Jan 2, 2021

This is a tiny PR to fix a typo in the parser help menu

@xinbinhuang xinbinhuang requested a review from a team as a code owner January 2, 2021 22:09
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase labels Jan 2, 2021
@xinbinhuang xinbinhuang changed the title Fix small typo in parser docs: Fix small typo in parser Jan 2, 2021
@JoanFM
Copy link
Member

JoanFM commented Jan 2, 2021

recheckcla

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

Jina CLA check ✅ All Contributors have signed the CLA.

@JoanFM
Copy link
Member

JoanFM commented Jan 2, 2021

Bad commit message, please refer to:

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1699, delta to last 3 avg.: +0%
  • 😶 query QPS at 31, delta to last 3 avg.: -5%

Breakdown

Version Index QPS Query QPS
current 1699 31
0.8.21 1733 32
0.8.20 1672 32
0.8.19 1740 32

Backed by latency-tracking. Further commits will update this comment.

@xinbinhuang xinbinhuang changed the title docs: Fix small typo in parser docs: Fix small typo in cli parser Jan 3, 2021
@xinbinhuang xinbinhuang changed the title docs: Fix small typo in cli parser docs(cli): Fix small typo in cli parser Jan 3, 2021
@xinbinhuang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@xinbinhuang
Copy link
Contributor Author

@JoanFM hmm, I am a bit confused about what commit messages should I change it to. Do you mind giving me a pointer?

@JoanFM
Copy link
Member

JoanFM commented Jan 3, 2021

@JoanFM hmm, I am a bit confused about what commit messages should I change it to. Do you mind giving me a pointer?

if u look at the CI, this error shows up

"/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/jina/jina":"/github/workspace" wagoid/commitlint-github-action:1.8.0
Error: You have commit messages with errors

⧗ input: docs(cli): Fix small typo in parser
✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]

✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlin

@codecov
Copy link

codecov bot commented Jan 3, 2021

Codecov Report

Merging #1578 (35517e4) into master (0445070) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1578      +/-   ##
==========================================
+ Coverage   84.08%   84.39%   +0.30%     
==========================================
  Files         128      128              
  Lines        6587     6656      +69     
==========================================
+ Hits         5539     5617      +78     
+ Misses       1048     1039       -9     
Impacted Files Coverage Δ
jina/logging/sse.py 92.75% <0.00%> (-2.56%) ⬇️
jina/jaml/helper.py 92.30% <0.00%> (-0.86%) ⬇️
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/flow/base.py 86.58% <0.00%> (-0.41%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb55b1...35517e4. Read the comment docs.

@xinbinhuang
Copy link
Contributor Author

@JoanFM Thanks for the info! I have fixed the commit lint, but one of the CI is still failing. Is it relevant to this PR?

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit c9f6e59 into jina-ai:master Jan 4, 2021
@xinbinhuang xinbinhuang deleted the fix_typo branch January 4, 2021 06:22
Copy link
Member

@CatStark CatStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants