Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add readme.es.md #1579

Merged

Conversation

PabloRN
Copy link
Contributor

@PabloRN PabloRN commented Jan 3, 2021

Spanish version of readme.md

@PabloRN PabloRN requested a review from hanxiao as a code owner January 3, 2021 10:06
@jina-bot jina-bot added size/M area/housekeeping This issue/PR is housekeeping labels Jan 3, 2021
@PabloRN PabloRN changed the title Adding readme.es.md docs: Adding readme.es.md Jan 3, 2021
@PabloRN PabloRN changed the title docs: Adding readme.es.md docs: Add readme.es.md Jan 3, 2021
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PabloRN , thank you very much for your help, there are some changes I think that would improve the translation

.github/i18n/README.es.md Outdated Show resolved Hide resolved
.github/i18n/README.es.md Outdated Show resolved Hide resolved
.github/i18n/README.es.md Outdated Show resolved Hide resolved
.github/i18n/README.es.md Outdated Show resolved Hide resolved
.github/i18n/README.es.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 3, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1518, delta to last 3 avg.: -1%
  • 😶 query QPS at 25, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1518 25
0.8.18 1535 26

Backed by latency-tracking. Further commits will update this comment.

@PabloRN PabloRN requested a review from a team as a code owner January 3, 2021 11:25
@JoanFM
Copy link
Member

JoanFM commented Jan 3, 2021

v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/jina/jina":"/github/workspace" wagoid/commitlint-github-action:1.8.0
Error: You have commit messages with errors

⧗ input: docs: Indización by Indexación
✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]

Bad commit message, please refer to:

@JoanFM
Copy link
Member

JoanFM commented Jan 3, 2021

recheckcla

@codecov
Copy link

codecov bot commented Jan 3, 2021

Codecov Report

Merging #1579 (58fb458) into master (3f5a588) will increase coverage by 0.01%.
The diff coverage is 85.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
+ Coverage   84.37%   84.39%   +0.01%     
==========================================
  Files         108      128      +20     
  Lines        6311     6656     +345     
==========================================
+ Hits         5325     5617     +292     
- Misses        986     1039      +53     
Impacted Files Coverage Δ
jina/clients/helper.py 94.00% <ø> (+15.31%) ⬆️
jina/drivers/predict.py 89.83% <0.00%> (ø)
jina/executors/metas.py 96.87% <ø> (ø)
jina/parsers/check.py 0.00% <0.00%> (ø)
jina/parsers/export_api.py 0.00% <0.00%> (ø)
jina/parsers/hub/new.py 0.00% <0.00%> (ø)
jina/parsers/logger.py 0.00% <0.00%> (ø)
jina/peapods/runtimes/asyncio/grpc/async_call.py 97.91% <ø> (ø)
jina/peapods/runtimes/ssh/__init__.py 36.84% <36.84%> (ø)
jina/jaml/parsers/flow/legacy.py 50.00% <37.50%> (-2.64%) ⬇️
... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a427b...5a314cd. Read the comment docs.

@JoanFM
Copy link
Member

JoanFM commented Jan 3, 2021

recheckcla

1 similar comment
@nan-wang
Copy link
Member

nan-wang commented Jan 4, 2021

recheckcla

@PabloRN
Copy link
Contributor Author

PabloRN commented Jan 4, 2021

recheckcla @nan-wang @JoanFM

Hi, I already did a rebase to the commit so I can follow the right commit style. I assume "recheckcla" means to check the CLA-bot signature. Is that correct? I didn't find anything about it in the documentation.

@cristianmtr
Copy link
Contributor

recheckcla @nan-wang @JoanFM

Hi, I already did a rebase to the commit so I can follow the right commit style. I assume "recheckcla" means to check the CLA-bot signature. Is that correct? I didn't find anything about it in the documentation.

Yes, that's correct. For some reason now it's not being triggered. We are looking into it. Meanwhile, can you try writing this in a comment (only this)

I have read the CLA Document and I hereby sign the CLA ?

The CLA is here https://github.com/jina-ai/jina/blob/master/.github/CLA.md

@PabloRN
Copy link
Contributor Author

PabloRN commented Jan 4, 2021

I have read the CLA Document and I hereby sign the CLA

@jina-ai jina-ai locked and limited conversation to collaborators Jan 4, 2021
@nan-wang nan-wang merged commit a3c72e4 into jina-ai:master Jan 5, 2021
@PabloRN PabloRN deleted the docs--add-spanish-translation-to-readme branch January 5, 2021 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/housekeeping This issue/PR is housekeeping size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants