Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jinad): log streaming from remote #1584

Merged
merged 7 commits into from Jan 5, 2021
Merged

Conversation

deepankarm
Copy link
Member

No description provided.

@deepankarm deepankarm requested a review from a team as a code owner January 4, 2021 11:21
@deepankarm deepankarm marked this pull request as draft January 4, 2021 11:21
@jina-bot jina-bot added size/XS area/testing This issue/PR affects testing labels Jan 4, 2021
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1659, delta to last 3 avg.: +0%
  • 😶 query QPS at 28, delta to last 3 avg.: +1%

Breakdown

Version Index QPS Query QPS
current 1659 28
0.8.23 1699 27
0.8.22 1682 27
0.8.21 1619 27

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #1584 (af3c578) into master (35139e9) will increase coverage by 1.25%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
+ Coverage   83.44%   84.70%   +1.25%     
==========================================
  Files         128      128              
  Lines        6646     6727      +81     
==========================================
+ Hits         5546     5698     +152     
+ Misses       1100     1029      -71     
Impacted Files Coverage Δ
jina/docker/checker.py 82.14% <ø> (ø)
jina/docker/hubapi.py 80.23% <ø> (+7.18%) ⬆️
jina/excepts.py 100.00% <ø> (ø)
jina/peapods/runtimes/jinad/api.py 55.33% <16.66%> (+1.13%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 48.38% <46.66%> (-6.62%) ⬇️
jina/docker/hubio.py 73.10% <100.00%> (+11.46%) ⬆️
jina/types/sets/querylang.py 96.66% <100.00%> (+34.99%) ⬆️
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35139e9...b3d42e1. Read the comment docs.

@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality component/peapod and removed size/XS labels Jan 4, 2021
@deepankarm deepankarm changed the title chore: check ci tests for jinad refactor(jinad): log streaming from remote Jan 5, 2021
JoanFM
JoanFM previously approved these changes Jan 5, 2021
@deepankarm deepankarm marked this pull request as ready for review January 5, 2021 18:44
@deepankarm deepankarm merged commit cd2ddb1 into master Jan 5, 2021
@deepankarm deepankarm deleted the chore-jinad-tests branch January 5, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants