Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip flaky tests #1598

Merged
merged 1 commit into from
Jan 5, 2021
Merged

test: skip flaky tests #1598

merged 1 commit into from
Jan 5, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jan 5, 2021

these two flaky tests slow us down. the reason of flaky remains unknown

@hanxiao hanxiao requested a review from a team as a code owner January 5, 2021 19:32
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1472, delta to last 3 avg.: -1%
  • 😶 query QPS at 25, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1472 25
0.9.1 1467 26
0.8.22 1494 25
0.8.21 1525 26

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1598 (a5a962c) into master (692c2d9) will increase coverage by 0.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   83.92%   84.92%   +0.99%     
==========================================
  Files         128      128              
  Lines        6674     6731      +57     
==========================================
+ Hits         5601     5716     +115     
+ Misses       1073     1015      -58     
Impacted Files Coverage Δ
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
jina/executors/indexers/vector.py 93.15% <0.00%> (+0.14%) ⬆️
jina/peapods/runtimes/asyncio/rest/__init__.py 93.18% <0.00%> (+0.15%) ⬆️
jina/flow/builder.py 73.91% <0.00%> (+0.28%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692c2d9...c320672. Read the comment docs.

@hanxiao hanxiao merged commit 3a90cbb into master Jan 5, 2021
@hanxiao hanxiao deleted the chore-flaky-tests branch January 5, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants