Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hubapi duplicate method definition #1601

Merged

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner January 5, 2021 20:57
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/docker labels Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1503, delta to last 3 avg.: +2%
  • 😶 query QPS at 25, delta to last 3 avg.: +1%

Breakdown

Version Index QPS Query QPS
current 1503 25
0.9.2 1494 23
0.9.1 1464 25
0.8.22 1457 24

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1601 (7273103) into master (692c2d9) will increase coverage by 1.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
+ Coverage   83.92%   84.94%   +1.02%     
==========================================
  Files         128      128              
  Lines        6674     6723      +49     
==========================================
+ Hits         5601     5711     +110     
+ Misses       1073     1012      -61     
Impacted Files Coverage Δ
jina/docker/hubapi.py 83.64% <50.00%> (+10.59%) ⬆️
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/flow/base.py 86.58% <0.00%> (+0.10%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
jina/executors/indexers/vector.py 93.15% <0.00%> (+0.14%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e28fe...7273103. Read the comment docs.

@florian-hoenicke florian-hoenicke merged commit 44d850a into master Jan 5, 2021
@florian-hoenicke florian-hoenicke deleted the refactor-hubapi-duplicate-method-definition branch January 5, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/docker size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants