Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test for embedding evaluators #1603

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner January 5, 2021 22:34
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Jan 5, 2021
@JoanFM
Copy link
Member

JoanFM commented Jan 5, 2021

just as comment, better use test: and not feat: for these commits

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1603 (0a20be6) into master (043a2bf) will increase coverage by 0.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1603      +/-   ##
==========================================
+ Coverage   83.92%   84.77%   +0.85%     
==========================================
  Files         128      127       -1     
  Lines        6673     6719      +46     
==========================================
+ Hits         5600     5696      +96     
+ Misses       1073     1023      -50     
Impacted Files Coverage Δ
jina/logging/sse.py 91.42% <0.00%> (-0.76%) ⬇️
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/executors/decorators.py 91.11% <0.00%> (-0.17%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/evaluators/embedding/__init__.py
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/flow/base.py 86.58% <0.00%> (+0.10%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 043a2bf...1e41f72. Read the comment docs.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit ba9e9ae into master Jan 6, 2021
@nan-wang nan-wang deleted the feat-test-embedding-evaluators branch January 6, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants