fix: remove warning jina version missing from manifest #1619
Conversation
jina-bot
added
size/XS
area/core
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| _allowed = {'name', 'description', 'author', 'url', | |||
| 'documentation', 'version', 'vendor', 'license', 'avatar', | |||
| 'jina_version', 'platform', 'update', 'keywords'} | |||
| 'platform', 'update', 'keywords'} | |||
There was a problem hiding this comment.
If it's not there will it be allowed to be added?
There was a problem hiding this comment.
Well, we did accept to remove this right? I just want to remove the warning because it seems missleading
There was a problem hiding this comment.
Ok. Then maybe _allowed is the wrong name for this variable. It should be _expected or something like that
There was a problem hiding this comment.
I think we do not need all of them
There was a problem hiding this comment.
But then it's not about being allowed, it's about being required, perhaps
There was a problem hiding this comment.
I do not know what's the best logic or if there are required fields @deepankarm ?
There was a problem hiding this comment.
We have a list of required & a list of _allowed. ValueError is raised if something is missing from required & a warning is given if something is missing from _allowed.
https://github.com/jina-ai/jina/blob/master/jina/docker/hubio.py#L590
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
+ Coverage 84.14% 85.01% +0.87%
==========================================
Files 127 127
Lines 6642 6701 +59
==========================================
+ Hits 5589 5697 +108
+ Misses 1053 1004 -49
Continue to review full report at Codecov.
|
No description provided.