fix: fix eval name from driver #1623
Conversation
jina-bot
added
size/S
area/core
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
==========================================
+ Coverage 84.14% 85.08% +0.94%
==========================================
Files 127 127
Lines 6642 6699 +57
==========================================
+ Hits 5589 5700 +111
+ Misses 1053 999 -54
Continue to review full report at Codecov.
|
| evaluation.op_name = f'{self.exec.__class__.__name__}@{self.exec.eval_at}' | ||
| else: | ||
| evaluation.op_name = self.exec.__class__.__name__ |
There was a problem hiding this comment.
| evaluation.op_name = f'{self.exec.__class__.__name__}@{self.exec.eval_at}' | |
| else: | |
| evaluation.op_name = self.exec.__class__.__name__ | |
| evaluation.op_name = f'{self.exec.name}@{self.exec.eval_at}' | |
| else: | |
| evaluation.op_name = self.exec.name |
I think we can simply use .name attribute of the executor - one of the metas attribute of any Executor. Also, since eval_at is kind of BaseRankingEvaluator specific, the BaseRankingEvaluator could just have the following somewhere in __init__ of post_init:
if self.eval_at:
self.name += f`@{self.eval_at}`
There was a problem hiding this comment.
We could, but now changing again in Hub is too much?
There was a problem hiding this comment.
Why this will lead to many changes in Jina Hub?
There was a problem hiding this comment.
no, that is my bad.
The name is very noisy for what I have seen, though
There was a problem hiding this comment.
the name of the executor.
:type: str
:default: class name plus a random string
There was a problem hiding this comment.
I think the naming is better with the current changes
No description provided.