-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rewrite handling of missing keys for indexers #1628
Conversation
8229668
to
1c8f28d
Compare
1c8f28d
to
0f3b56b
Compare
0f3b56b
to
1340a8a
Compare
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Not sure why I can't reply to this comment: #1628 (comment) When we call an .update, the keys will be computed for the update anyway. The update will then call the delete with only the filtered out keys. If we don't do it this way, the .delete method will have to recalculate and filter out the missing keys. When |
1340a8a
to
13136f0
Compare
8b93831
to
3d8d678
Compare
ab1ae68
to
4e98eb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just organizational/cleanup comments.
570777b
to
512febb
Compare
512febb
to
4b484e9
Compare
This will be required for the CRUD integration tests suite
Raise
warning
- up to the user to interpret if that's expected or not