Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix escape flag in codecov #1635

Merged
merged 3 commits into from
Jan 9, 2021
Merged

ci: fix escape flag in codecov #1635

merged 3 commits into from
Jan 9, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jan 9, 2021

slash in flag is not escaped, seems like an upstream problem of codecov/codecov-action@v1

raised issue here: codecov/codecov-action#199

@jina-bot jina-bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jan 9, 2021
@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #1635 (e2c9e22) into master (e7ddd43) will decrease coverage by 7.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1635      +/-   ##
==========================================
- Coverage   80.66%   72.95%   -7.71%     
==========================================
  Files         126      126              
  Lines        6589     6589              
==========================================
- Hits         5315     4807     -508     
- Misses       1274     1782     +508     
Flag Coverage Δ
3.7 ?
cd ?
ci 72.95% <ø> (?)
core 72.95% <ø> (?)
integration 32.88% <ø> (?)
jinad 32.88% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/hub/pushpull.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/document/multimodal.py 34.00% <0.00%> (-64.00%) ⬇️
jina/executors/indexers/cache.py 34.28% <0.00%> (-61.43%) ⬇️
jina/executors/evaluators/embedding/cosine.py 36.66% <0.00%> (-56.67%) ⬇️
jina/executors/evaluators/embedding/euclidean.py 36.66% <0.00%> (-56.67%) ⬇️
jina/drivers/multimodal.py 36.11% <0.00%> (-55.56%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ddd43...e2f401c. Read the comment docs.

@hanxiao hanxiao requested a review from a team as a code owner January 9, 2021 10:01
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing and removed size/XS labels Jan 9, 2021
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1696, delta to last 3 avg.: +0%
  • 😶 query QPS at 32, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1696 32
0.9.3 1685 32
0.9.2 1725 32
0.9.1 1687 32

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 9b846d7 into master Jan 9, 2021
@hanxiao hanxiao deleted the fix-ci-escape branch January 9, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants