Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test with different typologies with needs param #1668

Merged
merged 2 commits into from Jan 13, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 12, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner January 12, 2021 16:50
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1668 (4a2a921) into master (5e1a423) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
+ Coverage   84.14%   84.17%   +0.02%     
==========================================
  Files         132      132              
  Lines        6831     6831              
==========================================
+ Hits         5748     5750       +2     
+ Misses       1083     1081       -2     
Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/api.py 75.65% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1a423...af90e34. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 12, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1540, delta to last 3 avg.: +2%
  • 😶 query QPS at 26, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1540 26
0.9.13 1504 26
0.9.12 1505 25

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit a3d06b9 into master Jan 13, 2021
@hanxiao hanxiao deleted the jinad-test-needs-topology branch January 13, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants