Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add binder snippet #1673

Merged
merged 2 commits into from Jan 12, 2021
Merged

docs: add binder snippet #1673

merged 2 commits into from Jan 12, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jan 12, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner January 12, 2021 21:40
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality labels Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1673 (1cdf249) into master (45a7c74) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
- Coverage   84.18%   84.14%   -0.05%     
==========================================
  Files         132      132              
  Lines        6831     6831              
==========================================
- Hits         5751     5748       -3     
- Misses       1080     1083       +3     
Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/api.py 74.34% <0.00%> (-8.56%) ⬇️
jina/peapods/runtimes/zmq/zed.py 90.41% <0.00%> (+2.05%) ⬆️
jina/peapods/peas/helper.py 97.87% <0.00%> (+2.12%) ⬆️
jina/peapods/pods/helper.py 96.87% <0.00%> (+3.12%) ⬆️
jina/peapods/runtimes/base.py 94.44% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40aee5...1cdf249. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 12, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1478, delta to last 3 avg.: +2%
  • 😶 query QPS at 25, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1478 25
0.9.13 1399 25
0.9.12 1474 25

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 7b60b8e into master Jan 12, 2021
@hanxiao hanxiao deleted the docs-add-binder branch January 12, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants