Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove GPU check in Executor #1674

Merged
merged 2 commits into from Jan 14, 2021
Merged

refactor: remove GPU check in Executor #1674

merged 2 commits into from Jan 14, 2021

Conversation

tadejsv
Copy link
Contributor

@tadejsv tadejsv commented Jan 12, 2021

As discussed in #1672 , currently _check_on_gpu method will disable GPU even in some cases where there is a perfectly fine CUDA installation on the machine.

It is better to leave it up to the users to ensure that CUDA/GPU is working - the errors from various deep learning frameworks should quickly tell them if something is missing anyways.

@tadejsv tadejsv requested a review from a team as a code owner January 12, 2021 22:32
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/executor executor/meta labels Jan 12, 2021
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For back compatibility, have u checked if there is any executor in the hub calling this method?

If they are, I would just have it pass, remove them from those hub executors and later remove it totally from here

@github-actions
Copy link

github-actions bot commented Jan 12, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1641, delta to last 3 avg.: +4%
  • 😶 query QPS at 28, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1641 28
0.9.13 1644 28
0.9.12 1496 28

Backed by latency-tracking. Further commits will update this comment.

@tadejsv
Copy link
Contributor Author

tadejsv commented Jan 12, 2021

For back compatibility, have u checked if there is any executor in the hub calling this method?

If they are, I would just have it pass, remove them from those hub executors and later remove it totally from here

Ok, I went over jina and jina hub codebase, looking for all instances of "gpu" (case insensitive). Nothing calls this method directly, and no hub pod is testing on GPU (they all either not set on_gpu, or set it to true if JINA_TEST_GPU is in environment, which it never is).

I have not found any other potential use of this method. But you can double check to be sure. I am not sure why the CI is failing

@JoanFM JoanFM closed this Jan 13, 2021
@JoanFM JoanFM reopened this Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1674 (d4f3de4) into master (a3d06b9) will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
- Coverage   84.42%   84.10%   -0.33%     
==========================================
  Files         132      132              
  Lines        6831     6831              
==========================================
- Hits         5767     5745      -22     
- Misses       1064     1086      +22     
Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/api.py 75.65% <0.00%> (-11.19%) ⬇️
jina/docker/hubio.py 62.04% <0.00%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e24d12...868f7b2. Read the comment docs.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 1fad5b6 into jina-ai:master Jan 14, 2021
@nan-wang nan-wang linked an issue Jan 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/executor executor/meta size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable using GPU for docker containers
4 participants