New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove GPU check in Executor #1674
refactor: remove GPU check in Executor #1674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For back compatibility, have u checked if there is any executor in the hub calling this method?
If they are, I would just have it pass, remove them from those hub executors and later remove it totally from here
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Ok, I went over jina and jina hub codebase, looking for all instances of "gpu" (case insensitive). Nothing calls this method directly, and no hub pod is testing on GPU (they all either not set I have not found any other potential use of this method. But you can double check to be sure. I am not sure why the CI is failing |
…xecutor-check-gpu
Codecov Report
@@ Coverage Diff @@
## master #1674 +/- ##
==========================================
- Coverage 84.42% 84.10% -0.33%
==========================================
Files 132 132
Lines 6831 6831
==========================================
- Hits 5767 5745 -22
- Misses 1064 1086 +22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
As discussed in #1672 , currently
_check_on_gpu
method will disable GPU even in some cases where there is a perfectly fine CUDA installation on the machine.It is better to leave it up to the users to ensure that CUDA/GPU is working - the errors from various deep learning frameworks should quickly tell them if something is missing anyways.