Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change batch_size to request_size #1677

Merged
merged 2 commits into from Jan 14, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 13, 2021

Breaking Change #1606

@JoanFM JoanFM requested a review from a team as a code owner January 13, 2021 09:33
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/helloworld This issue/PR affects the helloworld area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/peapod labels Jan 13, 2021
@github-actions
Copy link

github-actions bot commented Jan 13, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1581, delta to last 3 avg.: +0%
  • 😶 query QPS at 27, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1581 27
0.9.13 1580 27
0.9.12 1576 27

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM closed this Jan 13, 2021
@JoanFM JoanFM reopened this Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1677 (7cd59c5) into master (bfef4f0) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1677      +/-   ##
==========================================
- Coverage   84.39%   84.17%   -0.23%     
==========================================
  Files         132      132              
  Lines        6831     6830       -1     
==========================================
- Hits         5765     5749      -16     
- Misses       1066     1081      +15     
Impacted Files Coverage Δ
jina/helloworld/__init__.py 100.00% <ø> (ø)
jina/parsers/flow.py 100.00% <ø> (ø)
jina/peapods/runtimes/asyncio/grpc/async_call.py 93.75% <ø> (ø)
jina/clients/base.py 80.00% <100.00%> (ø)
jina/clients/request.py 91.66% <100.00%> (ø)
jina/clients/websockets.py 95.23% <100.00%> (ø)
jina/optimizers/flow_runner.py 100.00% <100.00%> (ø)
jina/parsers/client.py 100.00% <100.00%> (ø)
jina/parsers/helloworld.py 100.00% <100.00%> (ø)
jina/peapods/runtimes/jinad/api.py 75.65% <0.00%> (-9.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfef4f0...31da657. Read the comment docs.

@jina-bot jina-bot added the area/cli This issue/PR affects the command line interface label Jan 13, 2021
@JoanFM JoanFM closed this Jan 13, 2021
@JoanFM JoanFM reopened this Jan 13, 2021
@JoanFM JoanFM closed this Jan 13, 2021
@JoanFM JoanFM reopened this Jan 13, 2021
@hanxiao hanxiao merged commit 5530733 into master Jan 14, 2021
@hanxiao hanxiao deleted the refactor-request-size branch January 14, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helloworld This issue/PR affects the helloworld area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/peapod size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants