Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix avoid pushing to docker registry #1680

Merged
merged 1 commit into from Jan 13, 2021
Merged

ci: fix avoid pushing to docker registry #1680

merged 1 commit into from Jan 13, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 13, 2021

No description provided.

@JoanFM JoanFM requested a review from hanxiao as a code owner January 13, 2021 13:57
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jan 13, 2021
@github-actions
Copy link

github-actions bot commented Jan 13, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1672, delta to last 3 avg.: -1%
  • 😶 query QPS at 33, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1672 33
0.9.13 1736 33
0.9.12 1654 33

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM force-pushed the github-run-id branch 3 times, most recently from 6fc0d9b to 9f9104e Compare January 13, 2021 15:20
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1680 (4cc153f) into master (bfef4f0) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1680      +/-   ##
==========================================
- Coverage   84.39%   84.17%   -0.22%     
==========================================
  Files         132      132              
  Lines        6831     6831              
==========================================
- Hits         5765     5750      -15     
- Misses       1066     1081      +15     
Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/api.py 75.65% <0.00%> (-9.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfef4f0...4cc153f. Read the comment docs.

@JoanFM JoanFM force-pushed the github-run-id branch 6 times, most recently from f69546f to a6649cf Compare January 13, 2021 18:24
@JoanFM JoanFM changed the title ci: fix github run id ci: fix avoid pushing to docker registry Jan 13, 2021
@hanxiao hanxiao merged commit 85a30ba into master Jan 13, 2021
@hanxiao hanxiao deleted the github-run-id branch January 13, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants