New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge matches topk #1686
feat: merge matches topk #1686
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1686 +/- ##
==========================================
+ Coverage 84.20% 84.78% +0.57%
==========================================
Files 132 133 +1
Lines 6830 6820 -10
==========================================
+ Hits 5751 5782 +31
+ Misses 1079 1038 -41
Continue to review full report at Codecov.
|
- !SliceQL | ||
with: | ||
start: 0 | ||
end: $JINA_TOPK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has to be set arbitrarily and overriden by QueryLangDriver, but setting an env variable is bad since we do not know it will exist. you can write 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new syntax for env var substituion is https://docs.jina.ai/chapters/yaml/substitute.html#confval-${{ENV.var}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we should not consider this is there right?
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be good to add this in one test? maybe take an integration test and change the name and see it works. Plus remove the env var
No description provided.