Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge matches topk #1686

Merged
merged 3 commits into from Jan 15, 2021
Merged

feat: merge matches topk #1686

merged 3 commits into from Jan 15, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner January 14, 2021 12:46
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/resource labels Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1686 (16ae488) into master (5530733) will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1686      +/-   ##
==========================================
+ Coverage   84.20%   84.78%   +0.57%     
==========================================
  Files         132      133       +1     
  Lines        6830     6820      -10     
==========================================
+ Hits         5751     5782      +31     
+ Misses       1079     1038      -41     
Impacted Files Coverage Δ
jina/flow/base.py 87.01% <0.00%> (-0.56%) ⬇️
jina/parsers/hub/__init__.py 65.00% <0.00%> (-0.12%) ⬇️
jina/docker/hubapi.py
jina/docker/hubapi/local.py 81.70% <0.00%> (ø)
jina/docker/hubapi/remote.py 75.32% <0.00%> (ø)
jina/docker/checker.py 84.90% <0.00%> (+2.76%) ⬆️
jina/docker/hubio.py 70.27% <0.00%> (+7.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5530733...16ae488. Read the comment docs.

- !SliceQL
with:
start: 0
end: $JINA_TOPK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be set arbitrarily and overriden by QueryLangDriver, but setting an env variable is bad since we do not know it will exist. you can write 10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we should not consider this is there right?

@github-actions
Copy link

github-actions bot commented Jan 14, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1595, delta to last 3 avg.: +1%
  • 😶 query QPS at 26, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1595 26
0.9.13 1551 26
0.9.12 1583 26

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be good to add this in one test? maybe take an integration test and change the name and see it works. Plus remove the env var

@florian-hoenicke florian-hoenicke merged commit 8410137 into master Jan 15, 2021
@florian-hoenicke florian-hoenicke deleted the feat-merge-matches-topk branch January 15, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/resource size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants