Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(daemon): add cors #1683 #1687

Merged
merged 1 commit into from Jan 14, 2021
Merged

fix(daemon): add cors #1683 #1687

merged 1 commit into from Jan 14, 2021

Conversation

deepankarm
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1687 (cff8019) into master (5530733) will decrease coverage by 10.76%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1687       +/-   ##
===========================================
- Coverage   84.20%   73.44%   -10.77%     
===========================================
  Files         132      132               
  Lines        6830     6830               
===========================================
- Hits         5751     5016      -735     
- Misses       1079     1814      +735     
Impacted Files Coverage Δ
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/flow_runner.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-89.78%) ⬇️
jina/optimizers/discovery.py 0.00% <0.00%> (-80.27%) ⬇️
jina/types/document/multimodal.py 34.00% <0.00%> (-64.00%) ⬇️
jina/executors/evaluators/embedding/cosine.py 36.66% <0.00%> (-56.67%) ⬇️
jina/executors/evaluators/embedding/euclidean.py 36.66% <0.00%> (-56.67%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5530733...cff8019. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1549, delta to last 3 avg.: +3%
  • 😶 query QPS at 27, delta to last 3 avg.: +2%

Breakdown

Version Index QPS Query QPS
current 1549 27
0.9.13 1492 26
0.9.12 1501 26

Backed by latency-tracking. Further commits will update this comment.

@deepankarm deepankarm marked this pull request as draft January 14, 2021 13:41
@deepankarm deepankarm marked this pull request as ready for review January 14, 2021 14:53
@deepankarm deepankarm merged commit 122fdf4 into master Jan 14, 2021
@deepankarm deepankarm deleted the add-cors-daemon branch January 14, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants