refactor(hubio): push, login, docker auth #1691
Conversation
jina-bot
added
size/L
area/core
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
+ Coverage 84.20% 84.80% +0.60%
==========================================
Files 132 133 +1
Lines 6830 6820 -10
==========================================
+ Hits 5751 5784 +33
+ Misses 1079 1036 -43
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
| 'try "git submodule update --init" if you are in dev mode') | ||
| return {} | ||
|
|
||
| def add_hub(): |
There was a problem hiding this comment.
pass hub_images as param, otherwise is impossible to understand, u are refering hub_images before instantiation.
There was a problem hiding this comment.
I actually I think is more elegant to have get_hub and have it return a key, value tuple to put in ur hub_images and so u do not pass hub_images as argument.
There was a problem hiding this comment.
This is restructuring of the existing code. I would do this in the next PR, while fixing list
| return {} | ||
|
|
||
| def add_hub(): | ||
| m_yml = f'{info.module_finder.path}/manifest.yml' |
| f'please re-login using command: {colored("jina hub login", attrs=["bold"])}') | ||
| raise HubLoginRequired | ||
|
|
||
| def _make_hub_table_with_local(manifests, local_manifests): |
| return info_table | ||
|
|
||
|
|
||
| def _make_hub_table(manifests): |
No description provided.