Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support json print in loginfo #1693

Merged
merged 1 commit into from Jan 15, 2021
Merged

feat: support json print in loginfo #1693

merged 1 commit into from Jan 15, 2021

Conversation

cristianmtr
Copy link
Contributor

I found this more useful when debugging. I can just copy-paste the output into a JSON tree viewer, and collapse/expand as needed during inspection.

@cristianmtr cristianmtr requested a review from a team as a code owner January 14, 2021 17:22
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/driver labels Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1693 (688e57b) into master (5530733) will increase coverage by 0.85%.
The diff coverage is 78.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1693      +/-   ##
==========================================
+ Coverage   84.20%   85.05%   +0.85%     
==========================================
  Files         132      133       +1     
  Lines        6830     6827       -3     
==========================================
+ Hits         5751     5807      +56     
+ Misses       1079     1020      -59     
Impacted Files Coverage Δ
jina/docker/checker.py 84.90% <ø> (+2.76%) ⬆️
jina/docker/hubio.py 70.27% <74.35%> (+7.00%) ⬆️
jina/docker/hubapi/remote.py 75.32% <75.32%> (ø)
jina/parsers/hub/__init__.py 65.00% <80.00%> (-0.12%) ⬇️
jina/docker/hubapi/local.py 81.70% <81.70%> (ø)
jina/drivers/control.py 95.08% <85.71%> (-1.35%) ⬇️
jina/drivers/search.py 94.82% <100.00%> (+0.18%) ⬆️
jina/parsers/hub/login.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5530733...e8b63a1. Read the comment docs.

jina/drivers/control.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 14, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1646, delta to last 3 avg.: -2%
  • 😶 query QPS at 33, delta to last 3 avg.: +1%

Breakdown

Version Index QPS Query QPS
current 1646 33
0.9.13 1671 31
0.9.12 1714 32

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit c35296e into master Jan 15, 2021
@hanxiao hanxiao deleted the feat-loginfo-json branch January 15, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/driver size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants