fix: filtering missing keys accounts for values #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianmtr
requested review from
Roshanjossey,
rutujasurve94,
florian-hoenicke and
JoanFM
jina-bot
added
size/S
area/core
JoanFM
reviewed
Jan 14, 2021
| @@ -162,17 +162,31 @@ def flush(self): | |||
| except: | |||
| pass | |||
|
|
|||
| def _filter_nonexistent_keys(self, keys: Iterator, existent_keys: Iterator, check_path: str): | |||
| indices_to_drop = [] | |||
| def _filter_nonexistent_keys_values(self, keys: Iterator, values: Iterator, existent_keys: Iterator, check_path: str) -> Tuple[List, List]: | |||
There was a problem hiding this comment.
can the typehints be more specific as per which kind of iterators it gets?
There was a problem hiding this comment.
Not really. Each of the indexers have their own types. I had to add IgnoreWarnings comment on some
Codecov Report
@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
+ Coverage 84.82% 85.07% +0.24%
==========================================
Files 133 133
Lines 6833 6833
==========================================
+ Hits 5796 5813 +17
+ Misses 1037 1020 -17
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
cristianmtr
force-pushed
the
fix-mising-keys-indices
branch
from
5c8a5e3
to
76f9ef9
Compare
hanxiao
reviewed
Jan 15, 2021
cristianmtr
force-pushed
the
fix-mising-keys-indices
branch
from
76f9ef9
to
1d196d1
Compare
hanxiao
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.