-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optional disable uses_b/a if parallel is 1 #1711
Conversation
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Codecov Report
@@ Coverage Diff @@
## master #1711 +/- ##
==========================================
- Coverage 84.78% 84.73% -0.06%
==========================================
Files 133 133
Lines 6856 6857 +1
==========================================
- Hits 5813 5810 -3
- Misses 1043 1047 +4
Continue to review full report at Codecov.
|
3fac3af
to
a6e79fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a small test here?
sure, will |
a6e79fa
to
f53633e
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Changes introduced
Right now if we use
uses_before
oruses_after
it is added even when parallel is 1. Although it can be desired to have auses_after
oruses_before
it is more common to only want it when there are multiple Peas inside a Pod.Add an option to disable them if parallel is 1. Like this one can keep the same
Flow
structure forsharding
and nosharding
and just parametrize the number of parallels or other options while not wasting CPU and network hops by these extra Peas