-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimizer yaml interface #1726
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
- Coverage 85.55% 85.33% -0.23%
==========================================
Files 134 135 +1
Lines 6834 6893 +59
==========================================
+ Hits 5847 5882 +35
- Misses 987 1011 +24
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why current JAML parser does not work?
|
||
class MultiFlowRunner: | ||
class MultiFlowRunner(FlowRunner): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like a lot this pattern
Because the current JAML parser works ONLY for classes, which inherit from But on the other hand, that is exactly, what |
What I understand now, is that you do not want a It seems that this may be a thoughtful design to guarantee that every |
Since we just need a trivial parser for |
1ea9994
to
dc06168
Compare
dc06168
to
add32f3
Compare
* feat: added jsonlines loading * feat: some refactoring for more concistency * refactor(optimizers): refactor optuna optimizer parameter handling Co-authored-by: Maximilian Werk <maximilian.werk@jina.ai>
LGTM! |
This will enable using a .yml file for running the optimizer.
index_lines
andsearch_lines
data_type=DataInputType.AUTO
Regarding the JAML parsing: I am well aware that the current solution is not in line with how Flows, Executors and Drivers are handled. In case the current solution is not wanted due to broken consistency (or consequences which I have not understood yet), we could also write a simple parser, which is used, whenever no other "special" parser is needed. I would be super happy about better informed input here @hanxiao @JoanFM