Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor typo #1749

Merged
merged 2 commits into from
Jan 22, 2021
Merged

fix: minor typo #1749

merged 2 commits into from
Jan 22, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 21, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner January 21, 2021 16:49
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase labels Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #1749 (3681cda) into master (650f87e) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   85.18%   85.12%   -0.07%     
==========================================
  Files         134      134              
  Lines        6865     6862       -3     
==========================================
- Hits         5848     5841       -7     
- Misses       1017     1021       +4     
Impacted Files Coverage Δ
jina/parsers/peapods/pod.py 100.00% <ø> (ø)
jina/peapods/pods/helper.py 96.80% <ø> (-0.10%) ⬇️
jina/drivers/querylang/select.py 79.31% <0.00%> (-6.90%) ⬇️
jina/peapods/runtimes/zmq/zed.py 89.92% <0.00%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8878ccd...3681cda. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 21, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1163, delta to last 3 avg.: -13%
  • 😶 query QPS at 27, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1163 27
0.9.19 1160 26
0.9.18 1528 26

Backed by latency-tracking. Further commits will update this comment.

@Yongxuanzhang
Copy link
Contributor

Is there any specific reason to add the space here or it's just to make the formatting consistent?

@JoanFM
Copy link
Member Author

JoanFM commented Jan 21, 2021

Is there any specific reason to add the space here or it's just to make the formatting consistent?

If u try it in local, there is no space and the 2 worda appear together

Yongxuanzhang
Yongxuanzhang previously approved these changes Jan 21, 2021
Copy link
Contributor

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yongxuanzhang
Copy link
Contributor

Is there any specific reason to add the space here or it's just to make the formatting consistent?

If u try it in local, there is no space and the 2 worda appear together

Sure and thanks! Just realized that they are actually one sentence.

@JoanFM JoanFM merged commit 957e88a into master Jan 22, 2021
@JoanFM JoanFM deleted the minor-typo branch January 22, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants