test: use flow v1 in tests #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwanglzu
changed the title
JoanFM
reviewed
Jan 21, 2021
| with: | ||
| read_only: true | ||
| rest_api: true | ||
| port_expose: $JINA_GATEWAY_REST_PORT | ||
| pods: | ||
| encoder: | ||
| - name encoder: |
There was a problem hiding this comment.
are we sure the syntax is not - name: encoder?
There was a problem hiding this comment.
@JoanFM my bad.. updating
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Codecov Report
@@ Coverage Diff @@
## master #1752 +/- ##
==========================================
- Coverage 85.35% 81.06% -4.29%
==========================================
Files 135 135
Lines 6903 6903
==========================================
- Hits 5892 5596 -296
- Misses 1011 1307 +296
Continue to review full report at Codecov.
|
|
|
JoanFM
requested changes
Jan 22, 2021
JoanFM
previously approved these changes
Jan 22, 2021
JoanFM
previously approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapt flow v1 in all unit tests & distributed tests.