New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test crud example #1754
test: test crud example #1754
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
==========================================
+ Coverage 85.32% 85.35% +0.02%
==========================================
Files 135 135
Lines 6903 6903
==========================================
+ Hits 5890 5892 +2
+ Misses 1013 1011 -2
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for separated workspace param to be removed
) | ||
mock = mocker.Mock() | ||
|
||
def validate_granularity_1(resp): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems u arr validating granularity 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't granularity 0 on document level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but it seemed that u checked or set granularity 0 inside the test? I may have missunderstoof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see. It just asserts that the granularity of the documents from the search result is 0 assert doc.granularity == 0
.
However, the distance calculation is done on granularity level 1.
is there more left to do @JoanFM |
* test: crud example initial commit * test: crud example * refactor: crud example part 1 * refactor: crud example part 2
No description provided.