Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test crud example #1754

Merged
merged 5 commits into from Jan 24, 2021
Merged

test: test crud example #1754

merged 5 commits into from Jan 24, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@jina-bot jina-bot added size/M area/testing This issue/PR affects testing labels Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #1754 (07a189a) into master (e29734b) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
+ Coverage   85.32%   85.35%   +0.02%     
==========================================
  Files         135      135              
  Lines        6903     6903              
==========================================
+ Hits         5890     5892       +2     
+ Misses       1013     1011       -2     
Impacted Files Coverage Δ
jina/drivers/querylang/select.py 86.20% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29734b...07a189a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 21, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1201, delta to last 3 avg.: -17%
  • 😶 query QPS at 32, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1201 32
0.9.19 1220 32
0.9.18 1698 32

Backed by latency-tracking. Further commits will update this comment.

@florian-hoenicke florian-hoenicke marked this pull request as ready for review January 21, 2021 23:19
@florian-hoenicke florian-hoenicke requested a review from a team as a code owner January 21, 2021 23:19
@JoanFM JoanFM changed the title Test crud example test: test crud example Jan 22, 2021
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for separated workspace param to be removed

tests/integration/crud/advanced/flow-index.yml Outdated Show resolved Hide resolved
)
mock = mocker.Mock()

def validate_granularity_1(resp):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems u arr validating granularity 0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't granularity 0 on document level?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but it seemed that u checked or set granularity 0 inside the test? I may have missunderstoof

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see. It just asserts that the granularity of the documents from the search result is 0 assert doc.granularity == 0.
However, the distance calculation is done on granularity level 1.

tests/integration/crud/advanced/yaml/rank.yml Outdated Show resolved Hide resolved
@florian-hoenicke
Copy link
Member Author

is there more left to do @JoanFM

@hanxiao hanxiao merged commit e204a06 into master Jan 24, 2021
@hanxiao hanxiao deleted the test-crud-example branch January 24, 2021 10:49
deepankarm pushed a commit that referenced this pull request Jan 24, 2021
* test: crud example initial commit

* test: crud example

* refactor: crud example part 1

* refactor: crud example part 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants