Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove logserver #1757

Merged
merged 1 commit into from
Jan 22, 2021
Merged

refactor: remove logserver #1757

merged 1 commit into from
Jan 22, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 22, 2021

Breaking Changes #1606

@JoanFM JoanFM requested a review from a team as a code owner January 22, 2021 12:23
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/resource labels Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #1757 (6d59881) into master (1fffc52) will increase coverage by 4.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1757      +/-   ##
==========================================
+ Coverage   80.86%   85.33%   +4.46%     
==========================================
  Files         135      135              
  Lines        6893     6893              
==========================================
+ Hits         5574     5882     +308     
+ Misses       1319     1011     -308     
Impacted Files Coverage Δ
jina/jaml/__init__.py 95.83% <0.00%> (+1.19%) ⬆️
jina/drivers/evaluate.py 98.27% <0.00%> (+1.72%) ⬆️
jina/optimizers/flow_runner.py 84.44% <0.00%> (+2.22%) ⬆️
jina/flow/base.py 86.86% <0.00%> (+2.41%) ⬆️
jina/importer.py 65.08% <0.00%> (+2.58%) ⬆️
jina/clients/request.py 91.66% <0.00%> (+2.77%) ⬆️
jina/types/document/uid.py 86.53% <0.00%> (+3.84%) ⬆️
jina/logging/logger.py 82.40% <0.00%> (+4.00%) ⬆️
jina/peapods/runtimes/asyncio/grpc/async_call.py 93.75% <0.00%> (+4.16%) ⬆️
jina/clients/base.py 80.00% <0.00%> (+4.76%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fffc52...6a10ad0. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1194, delta to last 3 avg.: -17%
  • 😶 query QPS at 33, delta to last 3 avg.: +1%

Breakdown

Version Index QPS Query QPS
current 1194 33
0.9.19 1218 32
0.9.18 1666 32

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 6b0efb9 into master Jan 22, 2021
@hanxiao hanxiao deleted the rm-logserver branch January 22, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/resource size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants