Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper): improve deprecated decor #1761

Merged
merged 3 commits into from
Jan 22, 2021
Merged

fix(helper): improve deprecated decor #1761

merged 3 commits into from
Jan 22, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jan 22, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner January 22, 2021 15:30
@github-actions
Copy link

This PR closes: #1730

@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/client component/flow labels Jan 22, 2021
cristianmtr
cristianmtr previously approved these changes Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #1761 (76d92ac) into master (d800a58) will increase coverage by 0.06%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1761      +/-   ##
==========================================
+ Coverage   85.34%   85.40%   +0.06%     
==========================================
  Files         135      135              
  Lines        6897     6926      +29     
==========================================
+ Hits         5886     5915      +29     
  Misses       1011     1011              
Impacted Files Coverage Δ
jina/drivers/convert.py 100.00% <ø> (ø)
jina/drivers/evaluate.py 98.27% <ø> (ø)
jina/drivers/predict.py 89.65% <ø> (-0.18%) ⬇️
jina/flow/asyncio.py 68.18% <90.00%> (+8.18%) ⬆️
jina/clients/asyncio.py 77.77% <100.00%> (+6.34%) ⬆️
jina/drivers/reduce.py 100.00% <100.00%> (ø)
jina/flow/base.py 87.20% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a15472...76d92ac. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 22, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1409, delta to last 3 avg.: -14%
  • 😶 query QPS at 37, delta to last 3 avg.: +3%

Breakdown

Version Index QPS Query QPS
current 1409 37
0.9.19 1328 35
0.9.18 1981 36

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 780d626 into master Jan 22, 2021
@hanxiao hanxiao deleted the fix-1730 branch January 22, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/client component/flow size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants