Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add sortql to merge-matches-topk #1767

Merged
merged 1 commit into from Jan 24, 2021
Merged

fix: add sortql to merge-matches-topk #1767

merged 1 commit into from Jan 24, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 23, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner January 23, 2021 16:29
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/resource labels Jan 23, 2021
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #1767 (d928483) into master (60f80b2) will decrease coverage by 21.89%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1767       +/-   ##
===========================================
- Coverage   85.35%   63.46%   -21.90%     
===========================================
  Files         135      135               
  Lines        6903     6938       +35     
===========================================
- Hits         5892     4403     -1489     
- Misses       1011     2535     +1524     
Impacted Files Coverage Δ
jina/helloworld/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/components.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/helper.py 0.00% <0.00%> (-90.53%) ⬇️
jina/docker/hubapi/local.py 0.00% <0.00%> (-88.38%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f80b2...d928483. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1210, delta to last 3 avg.: -1%
  • 😶 query QPS at 31, delta to last 3 avg.: -5%

Breakdown

Version Index QPS Query QPS
current 1210 31
0.9.20 1229 32
0.9.19 1220 32

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit af31c32 into master Jan 24, 2021
@nan-wang nan-wang deleted the sort-topk branch January 24, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/resource size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants