Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(daemon): add daemon test back #1771

Merged
merged 4 commits into from Jan 24, 2021
Merged

test(daemon): add daemon test back #1771

merged 4 commits into from Jan 24, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jan 24, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner January 24, 2021 09:40
@github-actions
Copy link

This PR closes: #1733

@hanxiao hanxiao linked an issue Jan 24, 2021 that may be closed by this pull request
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/daemon area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing labels Jan 24, 2021
@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #1771 (9849617) into master (01d2be4) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1771      +/-   ##
==========================================
+ Coverage   85.44%   85.70%   +0.25%     
==========================================
  Files         135      135              
  Lines        6938     6924      -14     
==========================================
+ Hits         5928     5934       +6     
+ Misses       1010      990      -20     
Impacted Files Coverage Δ
jina/docker/hubio.py 69.79% <0.00%> (-1.04%) ⬇️
jina/flow/base.py 88.04% <0.00%> (+0.50%) ⬆️
jina/peapods/pods/helper.py 97.87% <0.00%> (+1.06%) ⬆️
jina/peapods/runtimes/jinad/client.py 79.85% <0.00%> (+7.46%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 91.83% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d2be4...9849617. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 24, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1134, delta to last 3 avg.: +0%
  • 😶 query QPS at 26, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1134 26
0.9.20 1120 26
0.9.19 1135 26

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit ce45e6d into master Jan 24, 2021
@hanxiao hanxiao deleted the fix-1733 branch January 24, 2021 10:13
deepankarm pushed a commit that referenced this pull request Jan 24, 2021
* test(daemon): add daemon test back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tests/distributed/test_against_external_daemon work
2 participants