Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(flow): remove extra param in base docs #1838

Merged
merged 2 commits into from Feb 4, 2021
Merged

Conversation

Yongxuanzhang
Copy link
Contributor

No description provided.

@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/flow labels Feb 3, 2021
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1207, delta to last 3 avg.: +0%
  • 😶 query QPS at 23, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1207 23
0.9.27 1216 23
0.9.26 1217 23

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1838 (cbf462f) into master (39116ee) will decrease coverage by 21.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1838       +/-   ##
===========================================
- Coverage   85.85%   64.04%   -21.82%     
===========================================
  Files         145      145               
  Lines        6944     6944               
===========================================
- Hits         5962     4447     -1515     
- Misses        982     2497     +1515     
Impacted Files Coverage Δ
jina/flow/base.py 85.78% <ø> (-2.25%) ⬇️
jina/helloworld/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/components.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/flow_runner.py 0.00% <0.00%> (-95.66%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39116ee...4f4eb4f. Read the comment docs.

@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review February 3, 2021 04:14
@Yongxuanzhang Yongxuanzhang requested a review from a team as a code owner February 3, 2021 04:14
Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 2189fa2 into master Feb 4, 2021
@nan-wang nan-wang deleted the docs-flow-base branch February 4, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/flow size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants