Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default value of workspace dir #1851

Merged
merged 1 commit into from Feb 4, 2021
Merged

Conversation

maximilianwerk
Copy link
Member

Better to take current local as default instead of / implicitly

@maximilianwerk maximilianwerk requested a review from a team as a code owner February 3, 2021 20:39
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase labels Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1851 (03ef176) into master (8ca3ba9) will decrease coverage by 7.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1851      +/-   ##
==========================================
- Coverage   86.00%   78.61%   -7.39%     
==========================================
  Files         146      146              
  Lines        6972     6972              
==========================================
- Hits         5996     5481     -515     
- Misses        976     1491     +515     
Impacted Files Coverage Δ
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/document/multimodal.py 34.00% <0.00%> (-64.00%) ⬇️
jina/executors/evaluators/embedding/cosine.py 36.66% <0.00%> (-56.67%) ⬇️
jina/executors/evaluators/embedding/euclidean.py 36.66% <0.00%> (-56.67%) ⬇️
jina/drivers/multimodal.py 36.11% <0.00%> (-55.56%) ⬇️
jina/drivers/predict.py 36.20% <0.00%> (-53.45%) ⬇️
jina/drivers/querylang/queryset/dunderkey.py 54.90% <0.00%> (-45.10%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca3ba9...03ef176. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1366, delta to last 3 avg.: -1%
  • 😶 query QPS at 26, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1366 26
0.9.27 1381 26
0.9.26 1386 26

Backed by latency-tracking. Further commits will update this comment.

Copy link
Contributor

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@maximilianwerk maximilianwerk merged commit df3e99a into master Feb 4, 2021
@maximilianwerk maximilianwerk deleted the fix-optimizer-interface branch February 4, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants