Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cache runtime optimization #1853

Merged
merged 3 commits into from Feb 4, 2021
Merged

refactor: cache runtime optimization #1853

merged 3 commits into from Feb 4, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/executor executor/indexer labels Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021 •
edited

Codecov Report

Merging #1853 (7f39882) into master (4dbf094) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1853      +/-   ##
==========================================
+ Coverage   85.92%   85.93%   +0.01%     
==========================================
  Files         146      146              
  Lines        6983     6981       -2     
==========================================
- Hits         6000     5999       -1     
+ Misses        983      982       -1
Impacted Files Coverage Δ
jina/drivers/cache.py 93.75% <100.00%> (ø)
jina/executors/indexers/cache.py 98.50% <100.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dbf094...48f9582. Read the comment docs.

@florian-hoenicke florian-hoenicke marked this pull request as ready for review February 3, 2021 23:00
@florian-hoenicke florian-hoenicke requested a review from a team as a code owner February 3, 2021 23:00
cristianmtr
cristianmtr suggested changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@cristianmtr cristianmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

@github-actions
Copy link

github-actions bot commented Feb 4, 2021 •
edited

Latency summary

Current PR yields:

  • 😶 index QPS at 1081, delta to last 3 avg.: +1%
  • 😶 query QPS at 18, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1081 18
0.9.28 1022 18
0.9.27 1098 19

Backed by latency-tracking. Further commits will update this comment.

@florian-hoenicke
Merge branch 'master' of https://github.com/jina-ai/jina into refacto…
48f9582 
…r-cache-runtime-optimization

# Conflicts:
#	jina/executors/indexers/cache.py
cristianmtr
cristianmtr suggested changes Feb 4, 2021
View reviewed changes
jina/executors/indexers/cache.py Show resolved Hide resolved
jina/executors/indexers/cache.py Show resolved Hide resolved
jina/executors/indexers/cache.py Outdated Show resolved Hide resolved
@florian-hoenicke florian-hoenicke merged commit a5c2213 into master Feb 4, 2021
@florian-hoenicke florian-hoenicke deleted the refactor-cache-runtime-optimization branch February 4, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr cristianmtr approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/executor executor/indexer size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@florian-hoenicke @cristianmtr @jina-bot