Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: is_merge should be False by default #1855

Merged
merged 4 commits into from
Feb 4, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion jina/drivers/search.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class KVSearchDriver(BaseSearchDriver):
- K is the top-k
"""

def __init__(self, is_merge: bool = True, traversal_paths: Tuple[str] = ('m'), *args, **kwargs):
def __init__(self, is_merge: bool = False, traversal_paths: Tuple[str] = ('m'), *args, **kwargs):
"""Construct the driver.

:param is_merge: when set to true the retrieved docs are merged into current message using :meth:`MergeFrom`,
Expand Down
1 change: 1 addition & 0 deletions tests/integration/level_depth/yaml/index-chunk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,5 @@ requests:
- !KVSearchDriver
with:
executor: chunkidx
is_merge: true
traversal_paths: ['m']
1 change: 1 addition & 0 deletions tests/integration/level_depth/yaml/index-doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ requests:
- !KVSearchDriver
with:
executor: docIndexer
is_merge: true
traversal_paths: ['m']