New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: is_merge should be False by default #1855
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
+ Coverage 85.92% 85.99% +0.06%
==========================================
Files 146 146
Lines 6983 6982 -1
==========================================
+ Hits 6000 6004 +4
+ Misses 983 978 -5
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure u change the parameter for the helloworld
example, since this broke it
Ran it locally with the newest changes, and it works |
As agreed,
is_merge
should beFalse
by default. See #1705 (comment)