Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: is_merge should be False by default #1855

Merged
merged 4 commits into from Feb 4, 2021

Conversation

cristianmtr
Copy link
Contributor

As agreed, is_merge should be False by default. See #1705 (comment)

@cristianmtr cristianmtr requested a review from a team as a code owner February 4, 2021 10:05
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/driver labels Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1855 (72af5d2) into master (4dbf094) will increase coverage by 0.06%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1855      +/-   ##
==========================================
+ Coverage   85.92%   85.99%   +0.06%     
==========================================
  Files         146      146              
  Lines        6983     6982       -1     
==========================================
+ Hits         6000     6004       +4     
+ Misses        983      978       -5     
Impacted Files Coverage Δ
jina/peapods/runtimes/asyncio/rest/app.py 77.55% <0.00%> (ø)
jina/proto/jina_pb2.py 100.00% <ø> (ø)
jina/drivers/querylang/reverse.py 100.00% <100.00%> (ø)
jina/drivers/querylang/select.py 89.65% <100.00%> (ø)
jina/drivers/querylang/sort.py 100.00% <100.00%> (ø)
jina/drivers/search.py 96.49% <100.00%> (ø)
jina/peapods/runtimes/jinad/client.py 78.67% <0.00%> (+3.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dbf094...910fed5. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1189, delta to last 3 avg.: +0%
  • 😶 query QPS at 23, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1189 23
0.9.28 1189 24
0.9.27 1199 23

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Feb 4, 2021
JoanFM
JoanFM previously requested changes Feb 4, 2021
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure u change the parameter for the helloworld example, since this broke it

@cristianmtr
Copy link
Contributor Author

make sure u change the parameter for the helloworld example, since this broke it

Ran it locally with the newest changes, and it works

@cristianmtr
Copy link
Contributor Author

cristianmtr commented Feb 4, 2021

image

@cristianmtr cristianmtr merged commit c526d2a into master Feb 4, 2021
@cristianmtr cristianmtr deleted the fix-kv-search-ismerge-false branch February 4, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/resource size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants